Catch deferred attribute exception #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
==========================================
- Coverage 98.72% 98.45% -0.28%
==========================================
Files 6 6
Lines 707 710 +3
==========================================
+ Hits 698 699 +1
- Misses 9 11 +2
Continue to review full report at Codecov.
|
slurms
force-pushed
the
fix-deferred-attributes
branch
from
66d3113 to
959786e
Compare
auvipy
approved these changes
Mar 29, 2019
1 task
Merged
mthuurne
added a commit
to ProtixIT/django-model-utils
that referenced
this pull request
Jun 12, 2024
This catch was introduced in jazzband#367, but subsequent discussion in jazzband#370, jazzband#381 and jazzband#382 suggests that it wasn't the proper solution. Now that `AbstractModelTrackerTests` is re-enabled and passing, it becomes clear that `AttributeError` is no longer raised during unit testing when using a recent Django version. Therefore I think it is safe to remove the `try`/`except`.
5 tasks
mthuurne
added a commit
to ProtixIT/django-model-utils
that referenced
this pull request
Jun 13, 2024
This catch was introduced in jazzband#367, but subsequent discussion in jazzband#370, jazzband#381 and jazzband#382 suggests that it wasn't the proper solution. Now that `AbstractModelTrackerTests` is re-enabled and passing, it becomes clear that `AttributeError` is no longer raised during unit testing when using a recent Django version. Therefore I think it is safe to remove the `try`/`except`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #331.
Solution
Catch the
AttributeErrorand return the underlying field value.Commandments
CHANGES.rstfile to describe the changes, and quote according issue withGH-<issue_number>.