-
-
Notifications
You must be signed in to change notification settings - Fork 133
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
I narrowed down these tests to aborting in a Koa app. This happened because: 1. Koa listens for the error event on the HTTP stream itself, and re-emits it on the app's own event emitter. 2. If there is no listener for an app error, Koa will deviate from the node default of crashing, and will instead log the error. 3. This particular error originates from within the HTTP stream, causing Koa to log the error message. I fixed this by actually _expecting_ one error to be emit from the app, adding an assertion to test this.
- Loading branch information
1 parent
46c9513
commit a341dc1
Showing
1 changed file
with
14 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters