Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.12.5 #4495

Merged
merged 5 commits into from
Apr 10, 2017
Merged

1.12.5 #4495

merged 5 commits into from
Apr 10, 2017

Conversation

GeoffreyBooth
Copy link
Collaborator

Per the changelog:

I also updated the docs generation using code from #4494, to use Markdown-It instead of Marked.

@GeoffreyBooth GeoffreyBooth requested a review from lydell April 9, 2017 22:47
Copy link
Collaborator

@lydell lydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little note.

@@ -44,7 +44,6 @@ li {
}
table {
margin: 16px 0 0 13px; padding: 0;
width: 690px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intended? Won't it make table much wider on large screens?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was stretching out the table of operators, which is why I took it out. The table of usage flags is now just the width of the code examples: http://rawgit.com/geoffreybooth/coffeescript/1.12.5/docs/v1/index.html

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@GeoffreyBooth
Copy link
Collaborator Author

@lydell if this looks good to you, do you mind cutting the release? 😄

@lydell
Copy link
Collaborator

lydell commented Apr 10, 2017

I'll try to remember doing it tonight.

@GeoffreyBooth GeoffreyBooth merged commit 72cf485 into jashkenas:master Apr 10, 2017
@lydell
Copy link
Collaborator

lydell commented Apr 10, 2017

@GeoffreyBooth Are you publishing to npm and stuff? Otherwise I'll go ahead and do that now.

@GeoffreyBooth
Copy link
Collaborator Author

I’m happy for you to do it 😄 I think when I published to coffeescript (no hyphen) I took the hyphen out of package.json before publishing. I wish I had written down exactly what I did. Maybe if you npm install [email protected] and compare it against npm install [email protected] you can see, or I can look into it but I won’t have time until Wednesday.

@lydell lydell deleted the 1.12.5 branch April 10, 2017 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants