Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.12.4 #4441

Merged
merged 12 commits into from
Feb 18, 2017
Merged

1.12.4 #4441

merged 12 commits into from
Feb 18, 2017

Conversation

GeoffreyBooth
Copy link
Collaborator

Per the changelog:

  • The cake commands have been updated, with new watch options for most tasks. Clone the CoffeeScript repo and run cake at the root of the repo to see the options.
  • Fixed a bug where exporting a referenced variable was preventing the variable from being declared.
  • Fixed a bug where the coffee command wasn’t working for a .litcoffee file.

Includes #4440, assuming that will be merged in soon. If that requires more work, I’ll merge that branch into this one as needed.

@GeoffreyBooth GeoffreyBooth requested a review from lydell February 15, 2017 07:32
releaseHeader('2017-02-15', '1.12.4', '1.12.3')
```

* The `cake` commands have been updated, with new `watch` options for most tasks. Clone the [CoffeeScript repo](https://github.com/jashkenas/coffeescript) and run `cake` at the root of the repo to see the options.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone who has worked on the CoffeeScript source code, this is easily the most exciting part of the changelog. But do "regular users" even care? I'm not sure that we should mention the changes to CoffeeScript's internal Cakefile here – might just be confusing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I thought it was worth mentioning because the docs mentioned the cake commands, though I've been removing those references. They're still mentioned all over the place in the wiki etc.

Cakefile Outdated
fs.watch 'test/',
interval: 200
recursive: yes
, (eventType, filename) ->
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naked leading comma is poor CoffeeScript style — wrap the object in braces.

@GeoffreyBooth
Copy link
Collaborator Author

@lydell I think this should be ready to go. This would be the last release before 2.0.0-alpha1 🍾

@lydell lydell merged commit 91e3f72 into jashkenas:master Feb 18, 2017
@lydell lydell deleted the 1.12.4 branch February 18, 2017 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants