Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2] Fix handling of parameters that are complex #4430

Merged
merged 17 commits into from
Feb 1, 2017
Merged

[CS2] Fix handling of parameters that are complex #4430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ed6d9c6
Add failing test per #4406
GeoffreyBooth Jan 21, 2017
5f5c039
If a parameter is a function call, define it in an expression within …
GeoffreyBooth Jan 21, 2017
a3f8091
Remove the space between `function` and `*` for generator functions, …
GeoffreyBooth Jan 21, 2017
658f503
We can collapse `isCall` into `isComplex`
GeoffreyBooth Jan 21, 2017
baac18e
Merge branch '2' of github.com:jashkenas/coffeescript into destructur…
GeoffreyBooth Jan 21, 2017
42a2039
Don’t need existence check here
GeoffreyBooth Jan 21, 2017
dbd8274
Merge branch '2' of github.com:jashkenas/coffeescript into destructur…
GeoffreyBooth Jan 24, 2017
c4b6d27
Correct destructured parameter default evaluation order with an incre…
GeoffreyBooth Jan 24, 2017
8fe3242
Try to pull complex parameters out of the parameter list if their ord…
GeoffreyBooth Jan 24, 2017
f96ce05
Add lots of comments about node special properties
GeoffreyBooth Jan 24, 2017
6e2e254
Follow the ES and CS2 convention of assigning parameter default value…
GeoffreyBooth Jan 25, 2017
67ff10c
Err on the side of caution in deciding whether a complex parameter is…
GeoffreyBooth Jan 25, 2017
afd66d6
Along with arrays and empty objects, also let values whose bases are …
GeoffreyBooth Jan 25, 2017
e64bb8e
Merge branch '2' into destructured-parameter-evaluation-order
GeoffreyBooth Jan 25, 2017
ce9e04d
Better way to check for undefined parameters when declaring them in a…
GeoffreyBooth Jan 26, 2017
c581e9e
Once we’ve put a complex parameter in the function body, all followin…
GeoffreyBooth Jan 26, 2017
7867cd5
Rename `isComplex` to `shouldCache` for clarity
GeoffreyBooth Jan 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
119 changes: 66 additions & 53 deletions lib/coffee-script/nodes.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion lib/coffee-script/sourcemap.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading