[CS2] Require Node 6.9.1+ #4341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alloc`; update our calls, and set the required version of Node to be >= 6.9.0, and set this to be 2.0.0-alpha for now
GeoffreyBooth
changed the title
new Buffer in favor of Buffer.from and `Buffer.…new Buffer is deprecated in Node 6
|
LGTM. Does it make sense to do something in master as well? For instance, |
|
Hmm, that’s clever. I suppose we could, though I’m not sure what benefit it would provide. |
GeoffreyBooth
changed the title
new Buffer is deprecated in Node 6
|
Should I maybe use a package.json version number like |
|
|
GeoffreyBooth
force-pushed
the
buffer-deprecations
branch
from
6054945 to
d465cb3
Compare
|
Any objections to merging this in? |
|
Not from me. |
gluons
added a commit
to gluons/gulp-json2cson
that referenced
this pull request
Jan 13, 2018
- Because CoffeeScript 2 requires Node 6+. (Ref: jashkenas/coffeescript#4341)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 6 deprecated
new Bufferin favor ofBuffer.fromandBuffer.alloc. This PR updates our calls toBufferto use the new syntax. As a result of that, I also set the required version of Node perpackage.jsonto be >= 6.9.1, and set the overall version of the project to be 2.0.0-alpha for now.