Split out properties from identifiers #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lydell
commented
Mar 5, 2016
lydell
commented
- Split out a PROPERTY token from the IDENTIFIER token.
- Split out Property from the Identifier in the grammar.
- Split out PropertyLiteral from IdentifierLiteral.
| @@ -413,6 +413,9 @@ exports.PassthroughLiteral = class PassthroughLiteral extends Literal | |||
| exports.IdentifierLiteral = class IdentifierLiteral extends Literal | |||
| isAssignable: -> @value not in RESERVED | |||
|
|
|||
| exports.PropertyLiteral = class PropertyLiteral extends Literal | |||
There was a problem hiding this comment.
PropertyLiteral is a pretty strange name. I think PropertyName is better.
|
LGTM. Please rebase and merge. |
- Split out a PROPERTY token from the IDENTIFIER token. - Split out Property from the Identifier in the grammar. - Split out PropertyLiteral from IdentifierLiteral.
lydell
added a commit
that referenced
this pull request
Mar 6, 2016
Split out properties from identifiers
lydell
referenced
this pull request
Sep 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.