Fixes #1871, close implicit objects in implicit returns #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
| @@ -405,12 +422,6 @@ test "#1961, #1974, regression with compound assigning to an implicit object", - | |||
|
|
|||
| eq obj.four, 4 | |||
|
|
|||
| test "#2207: Immediate implicit closes don't close implicit objects", -> | |||
There was a problem hiding this comment.
I don't understand. Why did this one have to be removed?
There was a problem hiding this comment.
That was a test for the old behavior, so I moved the code to the current test and modified it. The current PR is almost direct opposite of the functionality that this test used to test.
There was a problem hiding this comment.
No, not quite. There's a big difference between a: for b in c then b and a: b for b in c.
There was a problem hiding this comment.
Very very good catch!
|
@michaelficarra Fixed, thanks for the catch. |
|
Perfect. |
michaelficarra
added a commit
that referenced
this pull request
Jan 23, 2014
Fixes #1871, close implicit objects in implicit returns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes namely #1871 (comment).