Interface enhancements for cake (#1862) #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try | ||
| options = oparse.parse(args) | ||
| catch e | ||
| return badArgument "#{e}".match(/option: (.+)/)[1], "option" |
There was a problem hiding this comment.
I don't like this. We can't just pass along the error given by OptionParser?
There was a problem hiding this comment.
I've added a commit to do this, though with some hesitation. This produces the output
Error: unrecognized option: --help
instead of the simpler and more consistent
No such option: "--help"
|
LGTM |
|
Cool, merging. |
TrevorBurnham
added a commit
that referenced
this pull request
Nov 14, 2011
Interface enhancements for cake (#1862)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the current master, while using an invalid task name produces a simple message, an invalid option (flag) produces a stack trace, because the exception thrown by
OptionParserisn't caught (#1862). This pull request corrects that, instead producing, for example:The other thing this patch does is preface the task list with a message like this:
This becomes useful when the relevant
Cakefileis in a parent directory (feature introduced by #1687), as it will then saymaking things much easier for folks with a hierarchy of
Cakefiles.