-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2] Rewriter: Inline block comments in CSX not getting output #4629
Labels
Comments
Regular block comments are allowed within CSX: <div> {### A JSX comment ###} </div>
<div>
{###
Multiline
JSX comment
###}
</div> Though they’re not getting output at the moment. |
@GeoffreyBooth That's great! I didn't realize that its already in |
GeoffreyBooth
changed the title
[CS2] Comment in CSX
[CS2] Rewriter: Inline block comments in CSX not getting output
Aug 5, 2017
GeoffreyBooth
added a commit
to GeoffreyBooth/coffeescript
that referenced
this issue
Aug 24, 2017
…hat contain nothing but comments should not be optimized out
Fixed by #4659. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
JSX
has a comment syntax{/* */}
:Currently there is no corresponding comment syntax in
CSX
yet. However, a workaround does exist, by using{`/* */`}
:Should this workaround be documented, or implement a specific comment syntax for
CSX
?It can be
{### ###}
or{# }
or something else. There was some discussion on this topic in the depreciatedCJSX
jsdf/coffee-react-transform#41, andCJSX
actually implemented the syntax{# }
.The text was updated successfully, but these errors were encountered: