Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2] coffeescript-loader #4462

Closed
michael-ciniawsky opened this issue Mar 13, 2017 · 12 comments
Closed

[CS2] coffeescript-loader #4462

michael-ciniawsky opened this issue Mar 13, 2017 · 12 comments
Labels

Comments

@michael-ciniawsky
Copy link

michael-ciniawsky commented Mar 13, 2017

👋 We currently are a bit clueless how to handle upgrading coffeescript-loader to coffescript v2, the 'problem' is the package rename between v1/v2 from coffee-script to coffeescriptsince we handle the version via peerDependencies atm. But also coffeescript@latest seem to point to v1.12.x (v1), which would be fine for v1 support in coffeescript-loader. Can someone please confirm that at least versions >= 1.12 of the v1 branch will be available under coffeescript aswell? Thx in advance 😛

@mrmowgli
Copy link
Contributor

mrmowgli commented Mar 13, 2017 via email

@michael-ciniawsky
Copy link
Author

@mrmowgli yep, the tricky thing isn't setting e.g coffee-script && coffeescript in peerDependencies but when require() them both in the loader => Error

@jashkenas
Copy link
Owner

Pinging @GeoffreyBooth for his plans on this...

@GeoffreyBooth
Copy link
Collaborator

GeoffreyBooth commented Mar 13, 2017

The plan at the moment is that coffeescript will have all versions (going back to 1.8.x or so) through the latest, including future versions of 2.x (and 1.x if there are any more). Future releases of 2.x will be on coffeescript. You can simply consider coffeescript to be the new primary NPM module name for CoffeeScript.

coffee-script for now will only get the latest 1.x releases. If we determine that it’s safe for downstream tools to put 2.x on it as well, then it will become a mirror of coffeescript. But for now it’s stuck at 1.x, so please change your code to use coffeescript instead.

@michael-ciniawsky
Copy link
Author

@GeoffreyBooth Awesome 👍 just to confirm coffeesscript set as peerDependency will definitely not 'exclude' v1 users using >= 1.8.x ? 🙃 Can we use it now or is it in the transition phase?

@GeoffreyBooth
Copy link
Collaborator

@michael-ciniawsky You can use it now. coffeescript should already have all the same old versions as coffee-script, except I think it was 1.7.0 which NPM wouldn’t let me publish (I guess because it had already been published and unpublished). If that’s an issue I can reach out to NPM and ask them to override.

Also when I published I went by git tags; if someone happened to npm publish a version from a commit different than what was tagged, then the two repos have slightly different versions with the same version number (grr). But I don’t think that happened for any versions, at least not for any 1.12.x versions. Again if it did I hope the NPM maintainers would fix it for us.

@michael-ciniawsky
Copy link
Author

michael-ciniawsky commented Mar 13, 2017

@GeoffreyBooth kk we'll see 😛 should normally be fine. Last question 🙃, are there any breaking changes in the Node API between v1 => v2 ?

@GeoffreyBooth
Copy link
Collaborator

Aside from requiring coffeescript or coffeescript/register instead of coffee-script, no. See http://coffeescript.org/v2/#breaking-changes

@GeoffreyBooth
Copy link
Collaborator

But CS2 requires Node 7+; the compiler itself is now in ES2015 (features supported by Node 7 only) so that’s one thing to be aware of.

@GeoffreyBooth GeoffreyBooth changed the title coffeescript-loader [CS2] coffeescript-loader Mar 13, 2017
@michael-ciniawsky
Copy link
Author

@GeoffreyBooth Alright thx appreciated

@miloslavnosek
Copy link

miloslavnosek commented Jun 3, 2017

What do I do to use CS2 with coffee-loader? It keeps telling me that I need [email protected] to fullfill it's peer dependency and won't let me compile anything. I have coffeescript 2.0.0-beta2 in my project.

@GeoffreyBooth
Copy link
Collaborator

That's a question for coffee-loader. See webpack-contrib/coffee-loader#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants