Browser compiler should convert the string to load to UTF-8, in case …

…it is UTF-16 like the contents of a <script> block generally are (#4375)
jashkenas · Nov 28, 2016 · ac20f66 · ac20f66
1 parent 5c765f4
commit ac20f66
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/coffee-script/coffee-script.js b/lib/coffee-script/coffee-script.js
diff --git a/src/coffee-script.coffee b/src/coffee-script.coffee
@@ -24,7 +24,12 @@ base64encode = (src) -> switch
   when typeof Buffer is 'function'
     new Buffer(src).toString('base64')
   when typeof btoa is 'function'
-    btoa(src)
+    # The contents of a <script> block are encoded via UTF-16, so if any extended
+    # characters are used in the block, btoa will fail as it maxes out at UTF-8.
+    # See https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/Base64_encoding_and_decoding#The_Unicode_Problem
+    # for the gory details, and for the solution implemented here.
+    btoa encodeURIComponent(src).replace /%([0-9A-F]{2})/g, (match, p1) ->
+      String.fromCharCode '0x' + p1
   else
     throw new Error('Unable to base64 encode inline sourcemap.')