Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The search field value on the main page of bukuserver isn't always submitted on search #618

Closed
LeXofLeviafan opened this issue Nov 17, 2022 · 0 comments · Fixed by #623
Closed
Labels

Comments

@LeXofLeviafan
Copy link
Collaborator

The search form on the main page of bukuserver includes two checkboxes ("Deep search" & "Regex"), a text field ("Keyword") and the submit button ("Search"). When either (or both) of the checkboxes are set, submitting the form (whether by clicking the button or by hitting Enter) opens the bookmark/ page with the textfield value passed as a corresponding parameter (such as ?flt1_buku_search_regex=, ?flt2_buku_search_deep= or ?flt3_buku_search_deep_regex=), resulting in a page with corresponding filter ("buku: search regex", "buku: search deep" or "buku: search deep, regex").

Given that, one would assume that submitting the form without setting either checkbox would result in a page with "buku: search" filter (?flt2_buku_search=); however, what I'm getting instead is a regular bookmark/ page without parameters (and thus without any filters).

@LeXofLeviafan LeXofLeviafan changed the title The search field value on the main page of bukuserver isn't submitted on search The search field value on the main page of bukuserver isn't always submitted on search without checkboxes Nov 17, 2022
@LeXofLeviafan LeXofLeviafan changed the title The search field value on the main page of bukuserver isn't always submitted on search without checkboxes The search field value on the main page of bukuserver isn't always submitted on search Nov 17, 2022
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Nov 28, 2022
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Nov 30, 2022
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Nov 30, 2022
@jarun jarun closed this as completed in #623 Dec 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant