Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use event callback in handlers #2187

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Fix use event callback in handlers #2187

merged 1 commit into from
Jan 9, 2020

Conversation

deini
Copy link
Contributor

@deini deini commented Jan 9, 2020

Should help to keep the same reference for onChange and not re-render every time.

Closes #1804

@vercel
Copy link

vercel bot commented Jan 9, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/jared/formik-docs/9e3lg6pvn
✅ Preview: https://formik-docs-git-fork-deini-useeventcallback.jared.now.sh

@jaredpalmer jaredpalmer merged commit c959f47 into jaredpalmer:master Jan 9, 2020
@jaredpalmer
Copy link
Owner

Thanks.

@deini deini deleted the useEventCallback branch January 9, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onChange reference can cause performance issues
2 participants
@deini @jaredpalmer