bugfix/573 #614
Closed
bugfix/573 #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i need some pointers here on why its failing ubuntu tests if the only changes were to the macos backend! |
|
Test failure was due to issues in the packaging infrastructure relating to new releases of tox, fixed in main. |
per comment in 573, if user stores an empty string, it is returned to the if statement. in python, '' evaluates as false, resulting in it not deleting the secret before trying to set a new one. this results in an error
jaraco
reviewed
Dec 18, 2022
Comment on lines
+150
to
151
| if find_generic_password(name, service, username, not_found_ok=True) is not None: | ||
| delete_generic_password(name, service, username) |
There was a problem hiding this comment.
Even better, perhaps one should not pass not_found_ok and trap the NotFound error. Even better than that, invoke the deletion and suppress the NotFound. I'll do that separately. Thanks for raising this to my attention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per comment in #573, if user stores an empty string, it is returned to the if statement as
''. in python,''evaluates as false, resulting in it not deleting the secret before trying to set a new one. this results in an error