Delete the password even if blank. Fixes #573.

jaraco · Dec 18, 2022 · aa2a9bd · aa2a9bd
1 parent 22bcc9a
commit aa2a9bd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/keyring/backends/macOS/api.py b/keyring/backends/macOS/api.py
@@ -1,3 +1,4 @@
+import contextlib
 import ctypes
 from ctypes import (
     c_void_p,
@@ -147,7 +148,7 @@ def find_generic_password(kc_name, service, username, not_found_ok=False):
 
 
 def set_generic_password(name, service, username, password):
-    if find_generic_password(name, service, username, not_found_ok=True):
+    with contextlib.suppress(NotFound):
         delete_generic_password(name, service, username)
 
     q = create_query(

diff --git a/keyring/testing/backend.py b/keyring/testing/backend.py
@@ -71,7 +71,6 @@ def test_password_set_get(self):
         service = random_string(20)
         self.check_set_get(service, username, password)
 
-    @pytest.mark.xfail(reason="#573")
     def test_set_after_set_blank(self):
         service = random_string(20)
         username = random_string(20)