Reduce "shim types", introduce agreement.Block #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agreement.Block is similar to what was agreement.ProposableBlock, but rather than being an interface it is a concrete type. Therefore, there can be no confusion: A validated block is not an agreement.Block just because it has a Block() method. Instead, FinalizeBlock methods explicit copy their internal Block() objects into agreement.Block objects during finalization. This PR also eliminates node.validatedBlock as *ledgercore.ValidatedBlock implements agreement.ValidatedBlock already, no wrapper is needed. Blocks remain as immutable as before.
jannotti
added a commit
that referenced
this pull request
Apr 18, 2024
Reduce "shim types", introduce agreement.Block
jannotti
added a commit
that referenced
this pull request
Apr 18, 2024
Reduce "shim types", introduce agreement.Block
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
agreement.Block is similar to what was agreement.ProposableBlock, but rather than being an interface it is a concrete type. Therefore, there can be no confusion: A validated block is not an agreement.Block just because it has a Block() method.
Instead, FinalizeBlock methods explicit copy their internal Block() objects into agreement.Block objects during finalization.
This PR also eliminates node.validatedBlock as
*ledgercore.ValidatedBlock implements agreement.ValidatedBlock already, no wrapper is needed. Blocks remain as immutable as before.