is_last
should not be checked forValueFunction
#56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your wonderful project.
I think, here,
is_last
should not be checked forValueFunction
, since there's nonn.Identity()
here for the last block:Otherwise, the dimension may not be correctly handled:
e.g. For
horizon=32
anddim_mults=(1, 4, 8)
, a dimension-mismatch error would appear:This bug will not appear when horizon is small (0 // 2 =0), but will appear for large horizon.