Skip to content

Commit

Permalink
feat($animate): ensure CSS transitions can work with inherited CSS cl…
Browse files Browse the repository at this point in the history
…ass definitions

BREAKING CHANGE

ngAnimate addClass / removeClass animations are now applied right away. This means
that as soon as the animation starts the class will be added (addClass) or removed
(removeClass) to the element being animated instead of after the -add-active /
-remove-active animations are completed. This allows for animations outside of
ngAnimate to not conflict with $animate.

This commit introduces beforeAddClass and beforeRemoveClass animation event functions and
executes any addClass and removeClass event functions AFTER the class has been added or
removed (this is opposite functionality of how ngAnimate used to work when performing
JS-enabled animations addClass / removeClass animations). If your animation code relies on
any animations being performed prior to the class change then simply use the new
beforeAddClass and beforeRemoveClass animation event functions.

Finally, when animating show and hide animations using CSS transitions or keyframe animations,
ng-hide-remove doesn't require `display:block!important` for ng-hide-add anymore.
  • Loading branch information
matsko authored and jamesdaily committed Jan 27, 2014
1 parent 835aca0 commit c3ea448
Show file tree
Hide file tree
Showing 2 changed files with 501 additions and 285 deletions.
Loading

0 comments on commit c3ea448

Please sign in to comment.