Skip to content

Commit

Permalink
windows CI: use exact same command to prebuild (bevyengine#5352)
Browse files Browse the repository at this point in the history
# Objective

- Running examples on windows crash due to full disk
- The prebuild step was not being reused and consuming extra space

## Solution

- Use the exact same command to prebuild to ensure it will be reused
- Also on linux
  • Loading branch information
mockersf authored and james7132 committed Oct 28, 2022
1 parent 3789363 commit 8559bfc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,9 @@ jobs:
with:
toolchain: stable
- name: Build bevy
# this uses the same command as when running the example to ensure build is reused
run: |
cargo build --features "bevy_ci_testing,trace,trace_chrome"
TRACE_CHROME=trace-alien_cake_addict.json CI_TESTING_CONFIG=.github/example-run/alien_cake_addict.ron cargo build --example alien_cake_addict --features "bevy_ci_testing,trace,trace_chrome"
- name: Run examples
run: |
for example in .github/example-run/*.ron; do
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/validation-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,10 @@ jobs:
key: ${{ runner.os }}-windows-run-examples-${{ hashFiles('**/Cargo.toml') }}

- name: Build bevy
shell: bash
# this uses the same command as when running the example to ensure build is reused
run: |
cargo build --features "bevy_ci_testing"
WGPU_BACKEND=dx12 CI_TESTING_CONFIG=.github/example-run/alien_cake_addict.ron cargo build --example alien_cake_addict --features "bevy_ci_testing"
- name: Run examples
shell: bash
Expand Down

0 comments on commit 8559bfc

Please sign in to comment.