Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Manual UI" entry in README is out-of-date. #167

Closed
andriyDev opened this issue Nov 23, 2023 · 2 comments · Fixed by #177
Closed

"Manual UI" entry in README is out-of-date. #167

andriyDev opened this issue Nov 23, 2023 · 2 comments · Fixed by #177

Comments

@andriyDev
Copy link

bevy_egui::EguiContext is no longer a resource. This makes the example code not work!
@ASoldo
Copy link

ASoldo commented Nov 27, 2023

Same here.

cbrown1234 added a commit to cbrown1234/bevy-inspector-egui that referenced this issue Dec 24, 2023
@cbrown1234
fix example in readme
8eb5d45 
fixes jakobhellermann#167
@cbrown1234 cbrown1234 mentioned this issue Dec 24, 2023
Merged
@cbrown1234
Copy link
Contributor

Found an example that did the same thing:

bevy-inspector-egui/crates/bevy-inspector-egui/examples/integrations/side_panel.rs

Lines 23 to 29 in 1b727e3

let mut egui_context = world
.query_filtered::<&mut EguiContext, With<PrimaryWindow>>()
.single(world)
.clone();
egui::SidePanel::left("hierarchy")
.default_width(200.0)
.show(egui_context.get_mut(), |ui| {

I've raised a PR to fix it

jakobhellermann pushed a commit that referenced this issue Dec 27, 2023
@cbrown1234 @jakobhellermann
fix example in readme
0c01c75 
fixes #167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix example in readme cbrown1234/bevy-inspector-egui
3 participants
@ASoldo @andriyDev @cbrown1234