Fix "index out of range" when receiving a dual client/server Zipkin span #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
changed the title
Codecov ReportBase: 97.16% // Head: 97.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4160 +/- ##
==========================================
- Coverage 97.16% 97.12% -0.04%
==========================================
Files 295 296 +1
Lines 17431 17452 +21
==========================================
+ Hits 16937 16951 +14
- Misses 398 403 +5
- Partials 96 98 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Yuri Shkuro <[email protected]>
|
@albertteoh or @pavolloffay can I get a review plz? |
albertteoh
reviewed
Jan 15, 2023
cmd/collector/app/zipkin/zipkindeser/zipkindesermocks/mocks_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
|
thanks! |
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Feb 22, 2023
…pan (jaegertracing#4160) ## Which problem is this PR solving? - Resolves jaegertracing#3404 ## Short description of the changes - Handle case where one input zipkin span is transformed into two Jaeger spans, but still return response with the same length as input - Add a test for dial client/server span provided in jaegertracing#3404 - Side effect: refactor `cmd/collector/app/zipkin` to avoid circular dependencies Signed-off-by: Yuri Shkuro <[email protected]>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Mar 5, 2023
…pan (jaegertracing#4160) ## Which problem is this PR solving? - Resolves jaegertracing#3404 ## Short description of the changes - Handle case where one input zipkin span is transformed into two Jaeger spans, but still return response with the same length as input - Add a test for dial client/server span provided in jaegertracing#3404 - Side effect: refactor `cmd/collector/app/zipkin` to avoid circular dependencies Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: shubbham1215 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
cmd/collector/app/zipkinto avoid circular dependencies