Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: span tags of type int64 may lose precision #3958 PR No 2 #4034

Merged
merged 13 commits into from
Nov 9, 2022

Conversation

shubbham1215
Copy link
Contributor

@shubbham1215 shubbham1215 commented Nov 9, 2022

Avoid value precision loss

Signed-off-by: Shubham Sawaiker [email protected]

Which problem is this PR solving?

Short description of the changes

  • avoid display value precision loss in case of value overflow Number.MAX_VALUE

Previous PR was made from main branch because of which CI jobs were failing.
First PR link : #4023

shubbham1215 and others added 12 commits November 9, 2022 01:02
 [Bug]: span tags of type int64 may lose precision jaegertracing#3958

Signed-off-by: Shubham Sawaiker <[email protected]>
Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.13.0 to 1.14.0.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.13.0...v1.14.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/viper
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Shubham Sawaiker <[email protected]>
…tracing#4026)

Bumps [github.com/dgraph-io/badger/v3](https://github.com/dgraph-io/badger) from 3.2103.3 to 3.2103.4.
- [Release notes](https://github.com/dgraph-io/badger/releases)
- [Changelog](https://github.com/dgraph-io/badger/blob/main/CHANGELOG.md)
- [Commits](dgraph-io/badger@v3.2103.3...v3.2103.4)

---
updated-dependencies:
- dependency-name: github.com/dgraph-io/badger/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Shubham Sawaiker <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.29 to 2.1.31.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@ec3cf9c...c3b6fce)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Shubham Sawaiker <[email protected]>
Bumps [anchore/sbom-action](https://github.com/anchore/sbom-action) from 0.13.0 to 0.13.1.
- [Release notes](https://github.com/anchore/sbom-action/releases)
- [Commits](anchore/sbom-action@b7e8507...06e1094)

---
updated-dependencies:
- dependency-name: anchore/sbom-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Shubham Sawaiker <[email protected]>
[Bug]: span tags of type int64 may lose precision
[Bug]: span tags of type int64 may lose precision
@shubbham1215 shubbham1215 requested a review from a team as a code owner November 9, 2022 17:22
@mergify
Copy link

mergify bot commented Nov 9, 2022

⚠️ The sha of the head commit of this PR conflicts with #4023. Mergify cannot evaluate rules on this PR. ⚠️

@shubbham1215 shubbham1215 changed the title [Bug]: span tags of type int64 may lose precision #3958 PR No 2 [Bug]: span tags of type int64 may lose precision #3958 Nov 9, 2022
@shubbham1215 shubbham1215 changed the title [Bug]: span tags of type int64 may lose precision #3958 [Bug]: span tags of type int64 may lose precision #3958 PR No 2 Nov 9, 2022
@shubbham1215
Copy link
Contributor Author

@yurishkuro Opened a new PR. Thanks.

@yurishkuro yurishkuro enabled auto-merge (squash) November 9, 2022 20:15
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 97.18% // Head: 97.17% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (bf0e4f8) compared to base (84c0abc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4034      +/-   ##
==========================================
- Coverage   97.18%   97.17%   -0.02%     
==========================================
  Files         295      295              
  Lines       17390    17393       +3     
==========================================
  Hits        16901    16901              
- Misses        394      396       +2     
- Partials       95       96       +1     
Flag Coverage Δ
unittests 97.17% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
model/converter/json/from_domain.go 100.00% <100.00%> (ø)
plugin/storage/badger/spanstore/reader.go 95.49% <0.00%> (-0.72%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: span tags of type int64 may lose precision
2 participants