Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link to FOSSA and Artifact Hub to README #3964

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Added link to FOSSA and Artifact Hub to README #3964

merged 3 commits into from
Oct 14, 2022

Conversation

jkowall
Copy link
Contributor

@jkowall jkowall commented Oct 10, 2022

Signed-off-by: jkowall [email protected]

Which problem is this PR solving?

#3943
Fixing a couple of these items by adding two links to README. We will have to solve the signing of the builds and the SBOM generation

Short description of the changes

Added two links in the README.

@jkowall jkowall requested a review from a team as a code owner October 10, 2022 20:11
@jkowall jkowall requested a review from joe-elliott October 10, 2022 20:11
README.md Outdated
@@ -4,8 +4,9 @@
[![Project+Community stats][community-badge]][community-stats]
[![Unit Tests][ci-img]][ci]
[![Coverage Status][cov-img]][cov]
[![FOSSA Status][fossa-img]][ci]
[![Artifact Hub][artifacthub-img]
[![CI Status][ci]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to replace L5 with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, fixed it now. Thanks!

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 97.16% // Head: 97.16% // No change to project coverage 👍

Coverage data is based on head (c218796) compared to base (87a5820).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3964   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files         295      295           
  Lines       17389    17389           
=======================================
  Hits        16896    16896           
  Misses        397      397           
  Partials       96       96           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit 5f9cbb9 into jaegertracing:main Oct 14, 2022
@jkowall jkowall deleted the CLOMonitor-Fixes branch October 19, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants