-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tenancy for queries #3791
Merged
yurishkuro
merged 20 commits into
jaegertracing:main
from
esnible:flow-tenant-from-query-v4
Jul 21, 2022
+1,147
−142
Merged
Tenancy for queries #3791
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4c8cb90
Tenancy for queries
esnible 13ba70f
New parameter for RegisterGRPCGateway() test function
esnible 28a3f0d
More tests that are local to package itself
esnible 08a7069
Additional test cases to raise test coverage
esnible ac0ea75
Fix test
esnible da1389c
spelling
esnible 7a5d1d5
Rename file
esnible ec4b8b9
Refactor tenancy packages
esnible 98be160
restore empty_test.go as part of refactoring tenancy out of storage
esnible 42ee1e3
lint/gofumpt
esnible 9380b3b
Enforce tenancy on non-streaming gRPC and add additional tests
esnible 47cce6f
Test for tenant flow to storage for both streaming and unary RPC
esnible fc863d6
HTTP tenancy test
esnible ccb143f
Unit test for unary tenancy handler
esnible e161c43
Factor out rendundent test function
esnible 459ba2b
Address review comments
esnible 2f9dcda
Error name
esnible e37e37d
Refactor TenancyConfig to TenancyManager
esnible 156008a
Address review comments
esnible 0d02721
Refactor so that NewTenancyManager() only called from main and tests
esnible File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be covered by an interceptor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line only became part of the PR because of the rename from
TenancyConfig
toTenancyManager
. The collector doesn't use the interceptors, which were introduced for query. This PR is large; I propose backporting the new query interceptor to the collector should be in a follow-up.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1