Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic from gogo-codec when receiving OTLP over gRPC #3719

Merged
merged 1 commit into from
May 31, 2022

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented May 31, 2022

Resolves #3717

Fix custom gogo codec to allow OTLP data types

@yurishkuro yurishkuro requested a review from a team as a code owner May 31, 2022 16:15
@yurishkuro yurishkuro requested a review from pavolloffay May 31, 2022 16:15
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #3719 (e8e0a6b) into main (557ff71) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3719      +/-   ##
==========================================
- Coverage   97.49%   97.47%   -0.03%     
==========================================
  Files         269      271       +2     
  Lines       15934    16016      +82     
==========================================
+ Hits        15535    15611      +76     
- Misses        315      319       +4     
- Partials       84       86       +2     
Impacted Files Coverage Δ
pkg/gogocodec/codec.go 100.00% <100.00%> (ø)
cmd/collector/app/flags/flags.go 96.73% <0.00%> (-3.27%) ⬇️
cmd/query/app/static_handler.go 95.80% <0.00%> (-1.80%) ⬇️
cmd/collector/app/handler/grpc_handler.go 100.00% <0.00%> (ø)
cmd/collector/app/span_handler_builder.go 100.00% <0.00%> (ø)
pkg/config/tenancy/tenancy.go 100.00% <0.00%> (ø)
pkg/config/tenancy/flags.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 557ff71...e8e0a6b. Read the comment docs.

@yurishkuro yurishkuro merged commit bae4cee into jaegertracing:main May 31, 2022
@yurishkuro yurishkuro deleted the fix-otlp-grpc branch May 31, 2022 17:13
yurishkuro added a commit that referenced this pull request May 31, 2022
@yurishkuro yurishkuro changed the title Fix custom gogo codec to allow OTLP data Fix panic from gogo-codec when receiving OTLP over gRPC May 31, 2022
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic receiving spans from an otlptrace.Exporter over gRPC
1 participant