Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to enable/disable dependencies on rollover #3705

Merged
merged 1 commit into from
May 27, 2022

Conversation

rubenvp8510
Copy link
Contributor

@rubenvp8510 rubenvp8510 commented May 26, 2022

Signed-off-by: Ruben Vargas [email protected]

Which problem is this PR solving?

Short description of the changes

  • This PR adds a flag to enable/disable the dependencies on roll-over, if the dependencies is disabled it won't rollover dependencies index.

@rubenvp8510 rubenvp8510 requested a review from a team as a code owner May 26, 2022 06:03
@rubenvp8510 rubenvp8510 requested a review from albertteoh May 26, 2022 06:03
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #3705 (107fd63) into main (1f4d1d2) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 107fd63 differs from pull request most recent head 81eef32. Consider uploading reports for the commit 81eef32 to get more accurate results

@@            Coverage Diff             @@
##             main    #3705      +/-   ##
==========================================
+ Coverage   97.35%   97.37%   +0.02%     
==========================================
  Files         268      268              
  Lines       15746    15752       +6     
==========================================
+ Hits        15330    15339       +9     
+ Misses        328      326       -2     
+ Partials       88       87       -1     
Impacted Files Coverage Δ
cmd/es-rollover/app/flags.go 100.00% <100.00%> (ø)
cmd/es-rollover/app/index_options.go 100.00% <100.00%> (ø)
cmd/es-rollover/app/init/action.go 93.75% <100.00%> (ø)
cmd/es-rollover/app/lookback/action.go 100.00% <100.00%> (ø)
cmd/es-rollover/app/rollover/action.go 100.00% <100.00%> (ø)
cmd/query/app/static_handler.go 95.80% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f4d1d2...81eef32. Read the comment docs.

@yurishkuro
Copy link
Member

Could you please fill out "Which problem is this PR solving" section? Or is there a ticket that describes that?

frzifus
frzifus previously approved these changes May 26, 2022
@rubenvp8510 rubenvp8510 force-pushed the disable-dependency branch from 2d7390c to 81eef32 Compare May 26, 2022 23:24
@yurishkuro yurishkuro merged commit 88bfe91 into jaegertracing:main May 27, 2022
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants