Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jean-Hadrien Chabran [email protected]
Hello 👋 (reopening this with a proper feature branch)
Which problem is this PR solving?
I noticed that the release binaries do not include darwin/arm64, which is just about adding it to the build scripts.
Short description of the changes
I added a target in the Makefile and patched a few other scripts. You can see a successful binary build here https://github.com/jhchabran/jaeger/runs/4216116176?check_suite_focus=true and the release workflow uploads here: https://github.com/jhchabran/jaeger/releases/tag/v1.28.1
Please tell me if I have missed anything!