Fix es-archive namespace default values

[albertteoh]

Signed-off-by: albertteoh [email protected]

Which problem is this PR solving?

• Fixes Fix archive default values reported for ES and Cassandra #2853

Short description of the changes

• Sets the default config of "other" namespaces to the primary's default config.

• As discussed in Fix archive default values reported for ES and Cassandra #2853, the primary default of 72h is misleading to users because an archive fetch should have no "lookback" limit, fetching any traceID that is in archive storage.

  This PR also removes the --es-archive.max-span-age flag to avoid confusing users.

Testing

• Confirmed --es-archive.max-span-age no longer appears in --help for both query and collector.
• Confirmed archive defaults are correctly based on primary config defaults for both query and collector. E.g.:

      --es-archive.max-doc-count int                       The maximum document count to return from an Elasticsearch query. This will also apply to aggregations. (default 10000)

[codecov]

Codecov Report

Merging #2865 (c582fb7) into master (70e9df7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2865      +/-   ##
==========================================
- Coverage   95.93%   95.91%   -0.02%     
==========================================
  Files         223      223              
  Lines        9675     9679       +4     
==========================================
+ Hits         9282     9284       +2     
- Misses        325      326       +1     
- Partials       68       69       +1     

Impacted Files	Coverage Δ
plugin/storage/es/options.go	100.00% <100.00%> (ø)
cmd/collector/app/server/zipkin.go	73.07% <0.00%> (-3.85%)	⬇️
cmd/query/app/server.go	95.62% <0.00%> (-1.46%)	⬇️
plugin/storage/integration/integration.go	77.90% <0.00%> (+0.55%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e9df7...c582fb7. Read the comment docs.

[yurishkuro]

Might warrant a "breaking change" entry in the changelog

Pull request has been modified.

[albertteoh]

Might warrant a "breaking change" entry in the changelog

👍 Breaking change entry added.

[yurishkuro]

the ES integration tests don't seem to like this change

[albertteoh]

This should fix both the failing ES integration tests and Crossdock builds.

The cause was due to archive mode being enabled by default and attempting to either ping a non-existent ES for a version (failing ES integration test) or attempting to communicate with ES on the wrong (default) IP address (failing Crossdock builds).

The original behaviour was to have archive mode disabled.