-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more encodings for Kafka in OTel Ingester #2580
Conversation
86ce768
to
ce6ff12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind merging this PR (particularly if it allows @XSAM to do something interesting with the Jaeger OTel Ingester), but all of this functionality is still being discussed and this may change in the final version.
Signed-off-by: Sam Xie <[email protected]>
ce6ff12
to
ec31e8a
Compare
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I generally expect this to change, but don't think there's any issue adding this flexibility to the OTel components for now.
@XSAM looks like you need to sign some commits? Other than that LGTM
Signed-off-by: Sam Xie <[email protected]>
1f9ddec
to
a99043c
Compare
Pull request has been modified.
Codecov Report
@@ Coverage Diff @@
## master #2580 +/- ##
==========================================
- Coverage 95.31% 95.29% -0.03%
==========================================
Files 208 208
Lines 9281 9281
==========================================
- Hits 8846 8844 -2
- Misses 356 358 +2
Partials 79 79
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Are there any documentation changes required to accompany this? |
Given that this is all likely to change and none of this is documented I think this is fine. I tried to make it clear that this is all currently up for debate and may change. I think @XSAM is just experimenting with the Otel pieces and this was something they needed. |
Resolves #2579