-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase coverage on otel/app/defaultconfig and otel/app/defaultcomponents #2515
Conversation
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2515 +/- ##
==========================================
+ Coverage 95.38% 95.41% +0.02%
==========================================
Files 208 208
Lines 9219 9219
==========================================
+ Hits 8794 8796 +2
+ Misses 349 348 -1
+ Partials 76 75 -1
Continue to review full report at Codecov.
|
Name: "traces", | ||
InputType: configmodels.TracesDataType, | ||
Receivers: []string{"otlp", "jaeger"}, | ||
Processors: []string{"batch", "queued_retry"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm qretry should not be there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
queued_retry
is in here b/c of the missing testdata/addqueuedprocessor.yaml
. See my recent push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modified test panics when running locally.
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Apologies. I forgot the config file you noticed above. It's now been pushed and I believe tests should pass. |
Which problem is this PR solving?
Short description of the changes