Fix go vet warnings on Go 1.15 #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
approved these changes
Aug 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #2401 +/- ##
==========================================
- Coverage 95.63% 95.60% -0.04%
==========================================
Files 206 206
Lines 10549 10549
==========================================
- Hits 10089 10085 -4
- Misses 393 395 +2
- Partials 67 69 +2
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Aug 19, 2020
pkg/normalizer/service_name.go
Outdated
| @@ -54,7 +55,7 @@ func newServiceNameReplacer() *strings.Replacer { | |||
| oldnew := make([]string, 0, 2*(256-2-10-int('z'-'a'+1))) | |||
| for i := range mapping { | |||
| if mapping[i] != byte(i) { | |||
| oldnew = append(oldnew, string(i), string(mapping[i])) | |||
| oldnew = append(oldnew, fmt.Sprintf("%c", i), fmt.Sprintf("%c", mapping[i])) | |||
There was a problem hiding this comment.
I think the recommendation from 1.15 release notes is to use string(rune(i))
go vet reports 3 issues when using Go 1.15: go vet ./... crossdock/services/tracehandler_test.go:40:12: conversion from untyped int to TraceID (string) yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?) crossdock/services/tracehandler_test.go:252:90: conversion from untyped int to TraceID (string) yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?) pkg/normalizer/service_name.go:57:28: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?) Signed-off-by: Łukasz Mierzwa <[email protected]>
yurishkuro
changed the title
|
Thanks! You may want to do another PR bumping Go version in our CI and go.mod |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go vet reports 3 issues when using Go 1.15:
Signed-off-by: Łukasz Mierzwa [email protected]