Add Zipkin OTEL receiver #2247
Merged
Add Zipkin OTEL receiver #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
objectiser
approved these changes
May 15, 2020
| flags.String(CollectorHTTPHostPort, ports.PortToHostPort(ports.CollectorHTTP), "The host:port (e.g. 127.0.0.1:5555 or :5555) of the collector's HTTP server") | ||
| flags.String(CollectorGRPCHostPort, ports.PortToHostPort(ports.CollectorGRPC), "The host:port (e.g. 127.0.0.1:5555 or :5555) of the collector's GRPC server") | ||
| tlsFlagsConfig.AddFlags(flags) | ||
| } | ||
|
|
||
| // AddOTELZipkinFlags adds flag that are exposed by OTEL Zipkin receiver | ||
| func AddOTELZipkinFlags(flags *flag.FlagSet) { | ||
| flags.String(CollectorZipkinHTTPHostPort, ports.PortToHostPort(0), "The host:port (e.g. 127.0.0.1:5555 or :5555) of the collector's Zipkin server") |
There was a problem hiding this comment.
nit: may be could use the 9411 port number for these messages?
Codecov Report
@@ Coverage Diff @@
## master #2247 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 219 219
Lines 10648 10650 +2
=======================================
+ Hits 10240 10242 +2
- Misses 352 353 +1
+ Partials 56 55 -1
Continue to review full report at Codecov.
|
Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2241 (comment)
Zipkin receiver is configurable via Jaeger flag
collector.zipkin.host-port, hence to follow the same approach as for Jaeger receiver we should provide a wrapper that configures the endpoint every time the receiver is used.