Bump OTEL version and update exporters to use new API #2196
Conversation
pavolloffay
force-pushed
the
otel-update-exporters
branch
from
764d7b6 to
080e5af
Compare
|
@objectiser this is ready for review |
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
force-pushed
the
otel-update-exporters
branch
from
c6e76e6 to
716a2fc
Compare
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
|
|
Signed-off-by: Pavol Loffay <[email protected]>
| func (Factory) CreateTraceExporter(log *zap.Logger, cfg configmodels.Exporter) (component.TraceExporterOld, error) { | ||
| // This function implements OTEL component.ExporterFactory interface. | ||
| func (f Factory) CreateTraceExporter( | ||
| _ context.Context, |
There was a problem hiding this comment.
why do they pass context? Is it used as a replacement for Close()?
There was a problem hiding this comment.
Close has its own context. This context seems to be associated with application start event.
Signed-off-by: Pavol Loffay <[email protected]>
This was the case before now It seems to work, I am trying to investigate xdock failure. The processors will be handled as part of #2152 |
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2196 +/- ##
==========================================
+ Coverage 96.14% 96.16% +0.01%
==========================================
Files 219 219
Lines 10632 10632
==========================================
+ Hits 10222 10224 +2
+ Misses 353 352 -1
+ Partials 57 56 -1
Continue to review full report at Codecov.
|
|
The processors were causing issues in the CI. Without the processors CI seems to pass fine. I will keep them removed and install back in #2152 |
pavolloffay
changed the title
Currently blocked by open-telemetry/opentelemetry-collector#872 as we need a new translator frompdata.Tracesto Jaeger data model.