Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tchannel port from dockerfile and test #2118

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay [email protected]

@pavolloffay pavolloffay requested a review from a team as a code owner March 6, 2020 13:49
@pavolloffay pavolloffay requested a review from vprithvi March 6, 2020 13:49
Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - once CI passed.

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #2118 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2118      +/-   ##
==========================================
- Coverage   96.14%   96.10%   -0.04%     
==========================================
  Files         217      217              
  Lines       10538    10538              
==========================================
- Hits        10132    10128       -4     
- Misses        352      354       +2     
- Partials       54       56       +2     
Impacted Files Coverage Δ
cmd/query/app/server.go 91.78% <0.00%> (-2.74%) ⬇️
cmd/query/app/static_handler.go 86.84% <0.00%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9cdc98...ffc0249. Read the comment docs.

@pavolloffay pavolloffay merged commit 602cdf4 into jaegertracing:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants