Add before you push to the queue to prevent race condition on size #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Joe Elliott <[email protected]>
joe-elliott
force-pushed
the
fix-queue-race-condition
branch
from
4942e9d to
6aaa413
Compare
Codecov Report
@@ Coverage Diff @@
## master #2044 +/- ##
==========================================
- Coverage 97.4% 97.39% -0.01%
==========================================
Files 207 207
Lines 10315 10286 -29
==========================================
- Hits 10047 10018 -29
Misses 224 224
Partials 44 44
Continue to review full report at Codecov.
|
joe-elliott
changed the title
jpkrohling
approved these changes
Jan 28, 2020
| @@ -105,12 +105,13 @@ func (q *BoundedQueue) Produce(item interface{}) bool { | |||
| return false | |||
| } | |||
|
|
|||
| q.size.Add(1) | |||
There was a problem hiding this comment.
This actually looks like a real bug, we are subtracting in both code branches, but adding in only one. Good catch!
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #2042
Short description of the changes
Adding to size before we put an item in the channel prevents
q.size.Sub(1)hitting before the addition. This prevents the uint from underflowing to max value.This change fixed the issue described in #2042 in our environment.
cc @gouthamve