Use proxy env vars if they're configured #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoidyzoidzoid
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1910 +/- ##
=========================================
Coverage ? 98.43%
=========================================
Files ? 198
Lines ? 9706
Branches ? 0
=========================================
Hits ? 9554
Misses ? 116
Partials ? 36Continue to review full report at Codecov.
|
|
Could you please provide a business case in the PR description? There's no explanation why this change is needed. Please make sure the CI is green. |
|
I'll rebase and properly sign off my commits. |
Signed-off-by: William Stewart <[email protected]>
zoidyzoidzoid
force-pushed
the
zoid/use-proxy-env-vars
branch
from
967294c to
7a6e278
Compare
yurishkuro
approved these changes
Nov 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a custom
net/httpTransport for talking to Elastic Search that doesn't currently supportHTTP{,S}_PROXYenvironment variables, but Elastic Search might be only accessible via a Proxy for some corporate enterprise reasons or because you're using something like Envoy as a proxy for egress for service discovery.