Add connect-timeout for Cassandra #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sagar Anand <[email protected]>
sagaranand015
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1647 +/- ##
==========================================
+ Coverage 98.73% 98.73% +<.01%
==========================================
Files 193 193
Lines 9214 9219 +5
==========================================
+ Hits 9097 9102 +5
Misses 90 90
Partials 27 27
Continue to review full report at Codecov.
|
yurishkuro
changed the title
yurishkuro
requested changes
Jul 3, 2019
pkg/cassandra/config/config.go
Outdated
| @@ -32,6 +32,7 @@ type Configuration struct { | |||
| LocalDC string `yaml:"local_dc"` | |||
| ConnectionsPerHost int `validate:"min=1" yaml:"connections_per_host"` | |||
| Timeout time.Duration `validate:"min=500"` | |||
| ConnectTimeout time.Duration `validate:"min=600"` | |||
There was a problem hiding this comment.
this shouldn't have validate tag, since it's a new optional param, but should have yaml:"connect_timeout"
There was a problem hiding this comment.
Fair point, this is actually optional. Pushing Changes
Signed-off-by: Sagar Anand <[email protected]>
yurishkuro
approved these changes
Jul 3, 2019
|
Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sagar Anand [email protected]
Which problem is this PR solving?
Short description of the changes