Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span format tag for jaeger-collector #1493

Merged
merged 4 commits into from
Apr 25, 2019

Conversation

guo0693
Copy link
Contributor

@guo0693 guo0693 commented Apr 24, 2019

Signed-off-by: jung [email protected]

Which problem is this PR solving?

Short description of the changes

  • include span format tag for every processed span in the collector

include span format tag for every processed span in the collector

Signed-off-by: jung <[email protected]>
@guo0693
Copy link
Contributor Author

guo0693 commented Apr 24, 2019

Screen Shot 2019-04-24 at 16 58 40

Screenshot of running hotRod locally with the changes.

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7a1f334). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1493   +/-   ##
=========================================
  Coverage          ?   99.81%           
=========================================
  Files             ?      181           
  Lines             ?     8652           
  Branches          ?        0           
=========================================
  Hits              ?     8636           
  Misses            ?        8           
  Partials          ?        8
Impacted Files Coverage Δ
model/converter/thrift/jaeger/to_domain.go 100% <100%> (ø)
cmd/collector/app/span_processor.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1f334...284f598. Read the comment docs.

@yurishkuro yurishkuro merged commit f86da0a into jaegertracing:master Apr 25, 2019
@guo0693 guo0693 deleted the issue-1490 branch April 25, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add span format tag for each span
2 participants