Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added whitespace tolerance for value for ES servers and kafka brokers #1305

Merged
merged 2 commits into from
Jan 30, 2019

Conversation

verma-varsha
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • A stripWhiteSpace function is added for both ES and kafka
  • An additional whitespace is added to the strings used for testing

@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1525c84). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1305   +/-   ##
========================================
  Coverage          ?    100%           
========================================
  Files             ?     162           
  Lines             ?    7265           
  Branches          ?       0           
========================================
  Hits              ?    7265           
  Misses            ?       0           
  Partials          ?       0
Impacted Files Coverage Δ
plugin/storage/kafka/options.go 100% <100%> (ø)
plugin/storage/es/options.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1525c84...80567d0. Read the comment docs.

@karlpokus
Copy link
Contributor

@verma-varsha haha. You beat me to to it :) I also made a PR #1306

@ghost ghost assigned black-adder Jan 30, 2019
@ghost ghost added the review label Jan 30, 2019
@black-adder black-adder merged commit 6115665 into jaegertracing:master Jan 30, 2019
@ghost ghost removed the review label Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants