Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing release 1.9.0 #1292

Merged
merged 3 commits into from
Jan 21, 2019
Merged

Preparing release 1.9.0 #1292

merged 3 commits into from
Jan 21, 2019

Conversation

pavolloffay
Copy link
Member

Resolves #1184

Signed-off-by: Pavol Loffay [email protected]

@pavolloffay
Preparing release 1.9.0
fbcbdae 
Signed-off-by: Pavol Loffay <[email protected]>
@ghost ghost assigned pavolloffay Jan 20, 2019
@ghost ghost added the review label Jan 20, 2019
@pavolloffay
Minor improvements
54b55d8 
Signed-off-by: Pavol Loffay <[email protected]>
@codecov
Copy link

codecov bot commented Jan 20, 2019 •
edited
Loading

Codecov Report

Merging #1292 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1292   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         161     161           
  Lines        7210    7210           
======================================
  Hits         7210    7210

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 822360c...e27b05f. Read the comment docs.

objectiser
objectiser reviewed Jan 21, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md
Note that


- Add CLI configurable `es.max-num-spans` while retrieving spans from ES ([#1283](https://github.com/jaegertracing/jaeger/pull/1283), [@annanay25](https://github.com/annanay25))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in the breaking changes section - its just an additional (optional) parameter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is in breaking change section

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is my question - why is it in the breaking change section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It breaks requests with a large number of spans

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks

objectiser
objectiser approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to sort out the last DCO.

@pavolloffay
Copy link
Member Author

I will merge without, its just doc file. There were some merges to readme without dco

@pavolloffay pavolloffay merged commit aa30ce4 into jaegertracing:master Jan 21, 2019
@ghost ghost removed the review label Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@objectiser objectiser objectiser approved these changes

@black-adder black-adder Awaiting requested review from black-adder

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@tiffon tiffon Awaiting requested review from tiffon

@vprithvi vprithvi Awaiting requested review from vprithvi

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

Assignees

@pavolloffay pavolloffay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavolloffay @objectiser