Allow promise-like objects as loadUtilsOnInit option #1878
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1877
This solves the issue that angular can't load the utils script because zone.js wraps promises.
The utils loader currently does an instanceof check against the builtin Promise type. This doesn't work with wrapped promises, bluebird promises or other custom promises.
By wrapping the source() result in a
Promise.reslove()
, instead of the instanceof check, we're making sure that we're working with a promise.I've added a specific testcase for a custom thenable that works with this patch.