Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging setup within egg. #83

Open
JackLeo opened this issue Sep 20, 2012 · 1 comment
Open

Remove logging setup within egg. #83

JackLeo opened this issue Sep 20, 2012 · 1 comment

Comments

@JackLeo
Copy link

JackLeo commented Sep 20, 2012

As far as I understand it's meant to be used as library for other projects. Project might load more complex configuration (file logging, emails, sentry, etc).

I would suggest leaving constructing logger for project not for library.
https://github.com/j2labs/brubeck/blob/master/brubeck/request_handling.py#L639

@j2labs
Copy link
Owner

j2labs commented Sep 26, 2012

I like the way you're thinking about this. Looking forward to catching up with this idea.

On Wednesday, September 26, 2012 at 9:22 AM, Domantas wrote:

Projects are using logging module. Constructor should be left for program since logging might and will be used before constructing Brubeck class witch is just a plugin for program and then it causes bug that logging won't work at all - http://stackoverflow.com/questions/1943747/python-logging-before-you-run-logging-basicconfig
Will be submitting pull request shortly.


Reply to this email directly or view it on GitHub (#83 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants