Processing entry-point dependencies. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all dependencies. I was finding that if I `required`d files that also lived in my static files folders from my entry-point files, then any changes to the dependent files would not result in recompiling the entry-point file.
|
Can you rebase to resolve the conflicts, then I'm happy to merge. Thanks |
|
Okay, conflicts have been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I noticed that the compiler would not run when a dependent JS file which is
required in the entry-point file was modified, meaning the browserified output would be incorrect until the entry-point file itself was modified.I've just modified the
is_outdatedmethod to generate a list of dependencies and check if any of them are out of date as compared to the compiled browserified file.One thing to note is that it may very well be the case that the command to generate the list of dependencies takes just as long as actually compiling, which would mean we could simply force a recompile every time and it would take the same amount of time. Given that, it may not actually be worth while merging this pull request in, I just though I'd open it and give you the opportunity to do so if you wished.
Thanks!