Fixup BROWSERIFY_BINARY default #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h new simple_execute helper and hopefully on Windows fixing j0hnsmith#17 too
…, showing a compiler error instead of a somewhat cryptic 500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last pull request introduced a bug with the default BROWSERIFY_BINARY, since with the new
simple_execute_commandit doesn't work to pass the "env browsersify" as the first command argument — technically "env" would need to be the command and "browserify" would need to be the first argument.Rather than trying to handle that situation with "/usr/bin/env browserify", I've simply made the default be "browserify" instead and the same behavior should result. I'm hopeful this will also fix #17 for Windows users who have browserify in their path.
(This also adds documentation for
BROWSERIFY_BINARYtoo.)