Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion add some note about BROWSERIFY_BINARY #17

Closed
ivictbor opened this issue Dec 9, 2016 · 1 comment · Fixed by #19
Closed

Suggestion add some note about BROWSERIFY_BINARY #17

ivictbor opened this issue Dec 9, 2016 · 1 comment · Fixed by #19

Comments

@ivictbor
Copy link

ivictbor commented Dec 9, 2016 •
edited
Loading

Hi. Thanks for project.

Default value of BROWSERIFY_BINARY is

            pipeline_settings.get('BROWSERIFY_BINARY', '/usr/bin/env browserify'),

Which will not work on Windows. So may be it is good idea to mention about BROWSERIFY_BINARY option in readme.
@ivictbor ivictbor changed the title Suggestion add some note about PIPELINE_BROWSERIFY_BINARY Suggestion add some note about BROWSERIFY_BINARY Dec 9, 2016
@natevw
Copy link
Collaborator

natevw commented Jan 10, 2017 •
edited
Loading

Actually, this makes me realize an issue with #18 in that the default BROWSERIFY_BINARY will probably no longer work with the way I'm handling the commands :-/

Seems the solution to both the issue on Windows and the one I introduced would be to simply use 'browserify' as the default? It has to be in the PATH anyway for env to find it, so I don't see any advantage in the indirection, and as you've found there's downsides for cross-platform compatibility.

natevw added a commit to natevw/django-pipeline-browserify-patches that referenced this issue Jan 10, 2017
@natevw
simplify (and fix) default browserify binary so that it will work wit…
9f139c2 
…h new simple_execute helper and hopefully on Windows fixing j0hnsmith#17 too
@natevw natevw mentioned this issue Jan 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixup BROWSERIFY_BINARY default natevw/django-pipeline-browserify-patches
2 participants
@natevw @ivictbor