fix(op_crate/web): add padding on URLSearchParam (denoland#7905)

Fixes denoland#7888
iykekings · Oct 10, 2020 · 57496b8 · 57496b8
1 parent 80c285e
commit 57496b8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/cli/tests/unit/url_search_params_test.ts b/cli/tests/unit/url_search_params_test.ts
@@ -179,6 +179,12 @@ unitTest(function urlSearchParamsMissingPair(): void {
   assertEquals(searchParams.toString(), "c=4&a=54");
 });
 
+unitTest(function urlSearchParamsForShortEncodedChar(): void {
+  const init = { linefeed: "\n", tab: "\t" };
+  const searchParams = new URLSearchParams(init);
+  assertEquals(searchParams.toString(), "linefeed=%0A&tab=%09");
+});
+
 // If pair does not contain exactly two items, then throw a TypeError.
 // ref https://url.spec.whatwg.org/#interface-urlsearchparams
 unitTest(function urlSearchParamsShouldThrowTypeError(): void {

diff --git a/op_crates/web/11_url.js b/op_crates/web/11_url.js
@@ -803,7 +803,7 @@
 
   function encodeChar(c) {
     return [...encoder.encode(c)]
-      .map((n) => `%${n.toString(16)}`)
+      .map((n) => `%${n.toString(16).padStart(2, "0")}`)
       .join("")
       .toUpperCase();
   }