You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Today I have implemented this package, and found one issue with hidden controls.
Problem is that when controls like back button are hidden, they still render Touchable zone with onPress callback, that expects callback (see renderControl), but renderNullControl doesn't pass any callback to renderControl. This causes error callback is not a function when you tap on location where back button touch zone is.
I'd suggest modifying renderNullControl to pass empty callback function to renderControl method, or to modify renderControl to check if callback is set.
Please let me know which variant you'd like more and whether you want me to prepare pull request.
Thanks!
The text was updated successfully, but these errors were encountered:
Hi,
Today I have implemented this package, and found one issue with hidden controls.
Problem is that when controls like back button are hidden, they still render Touchable zone with onPress callback, that expects callback (see renderControl), but renderNullControl doesn't pass any callback to renderControl. This causes error
callback is not a function
when you tap on location where back button touch zone is.I'd suggest modifying
renderNullControl
to pass empty callback function torenderControl
method, or to modifyrenderControl
to check ifcallback
is set.Please let me know which variant you'd like more and whether you want me to prepare pull request.
Thanks!
The text was updated successfully, but these errors were encountered: