lfs: optimize path filtering #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisp
force-pushed
the
lfs/collect-objects-perf
branch
from
dcfb08f to
d42c17f
Compare
shcheklein
reviewed
May 4, 2024
shcheklein
reviewed
May 4, 2024
shcheklein
reviewed
May 4, 2024
sisp
force-pushed
the
lfs/collect-objects-perf
branch
from
d42c17f to
fe85b60
Compare
2 tasks
shcheklein
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've optimized LFS path filtering as we discussed in #338. The first optimization implements the suggestion in #338 (comment) to short-cut a single-path
includefilter. Here are the tests for the regex that extracts the path prefix: https://regex101.com/r/wBjHf0/1 Note that the extra\non regex101.com is only necessary to allow one test case per line, it isn't needed in the actual regex.The second optimization unionizes the filename regex patterns derived from Unix filename patterns and matches each path against the pre-compiled single regex, which is faster than matching against the Unix filename patterns individually. Also, it avoids intermediate list materialization but instead implements a streaming filter.As the two commits implement independent optimizations, I intend this PR to be rebase-merged without commit squashing.Partially fixes #338.