Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp run / repro: Drop --metrics. #9458

Merged
merged 2 commits into from
May 22, 2023
Merged

exp run / repro: Drop --metrics. #9458

merged 2 commits into from
May 22, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented May 16, 2023

Closes #9457

@daavoo daavoo self-assigned this May 16, 2023
@daavoo daavoo linked an issue May 16, 2023 that may be closed by this pull request
Remove repro/exp run --metrics flag #9457
Closed
@daavoo daavoo added the 3.0 label May 16, 2023
@daavoo daavoo force-pushed the 9457-remove-reproexp-run-metrics-flag branch from fb0038c to fb0ef09 Compare May 16, 2023 09:30
@daavoo daavoo changed the title repro: Drop --metrics. exp run / repro: Drop --metrics. May 16, 2023
@daavoo daavoo mentioned this pull request May 16, 2023
Merged
@codecov
Copy link

codecov bot commented May 16, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (e69deaa) 91.60% compared to head (36d8616) 91.60%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9458      +/-   ##
==========================================
- Coverage   91.60%   91.60%   -0.01%     
==========================================
  Files         489      489              
  Lines       38166    38143      -23     
  Branches     5469     5467       -2     
==========================================
- Hits        34962    34939      -23     
  Misses       2639     2639              
  Partials      565      565
Impacted Files Coverage Δ
dvc/commands/repro.py 100.00% <ø> (ø)
tests/func/test_repro.py 100.00% <ø> (ø)
dvc/commands/experiments/run.py 81.57% <100.00%> (-2.15%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo marked this pull request as ready for review May 16, 2023 14:10
@daavoo daavoo force-pushed the 9457-remove-reproexp-run-metrics-flag branch from fb0ef09 to 36d8616 Compare May 16, 2023 14:10
@skshetry skshetry removed the 3.0 label May 17, 2023
@skshetry skshetry added this to the 3.0 milestone May 19, 2023
@skshetry skshetry requested a review from dberenbaum May 22, 2023 10:32
@daavoo daavoo enabled auto-merge (rebase) May 22, 2023 11:21
@daavoo daavoo disabled auto-merge May 22, 2023 11:21
@skshetry skshetry merged commit 182728d into main May 22, 2023
@skshetry skshetry deleted the 9457-remove-reproexp-run-metrics-flag branch May 22, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skshetry skshetry skshetry approved these changes

@dberenbaum dberenbaum dberenbaum approved these changes

Assignees

@daavoo daavoo

Labels
breaking-change
Projects
No open projects
DVC
Archived in project
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Remove repro/exp run --metrics flag
3 participants
@daavoo @dberenbaum @skshetry